Bugfix/dup port createpayload#58
Open
akynaston wants to merge 2 commits into
Open
Conversation
… already present. The createPayload function had a bug that would add the port even if it was already there. This fix and test ensures if the port is already present, the port will be left as is in the resulting JWT. If someone provided the port as shown here, then createPayload would add it again, making the JWT audience invalid. Example configured line, including port 443. C:\Users\akynaston>frodo conn list https://openam-trivir-fairfax.forgeblocks.com:443/am Any unique substring or alias of a saved host can be used as the value for host parameter in all commands C:\Users\akynaston>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update has a test for each of the locations we add on a :443 or :80 to the url:
AdminOps.ts - getAccessTokenUrl
AuthenticateOps.ts - createPayload
The AdminOpts.ts instance did not have any bugs that I could find; so I just added a test, and exported the function being tested. The AuthenticateOps.ts did have a bug in createPayload - if the port was already provided, it was added again. This fix avoids that issue and proves the fix with tests.