Skip to content

bugfix: incorporate type filtering in commands and expand targetFilters #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brycentrivir wants to merge 1 commit into
base: bugfix/iga-fixes
Choose a base branch
from
Open

bugfix: incorporate type filtering in commands and expand targetFilters #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/lib/Help.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6656,8 +6656,8 @@ export const helpMetadata: MethodHelpDoc[] = [
},
{
typeName: "Glossary",
methodName: "readGlossarySchemaByNameAndObjectType",
signature: "readGlossarySchemaByNameAndObjectType( glossaryName: string, objectType: GlossaryObjectType ): Promise<GlossarySchemaItemSkeleton<any>>",
methodName: "readGlossarySchemaByName",
signature: "readGlossarySchemaByName( glossaryName: string, objectType?: GlossaryObjectType ): Promise<GlossarySchemaItemSkeleton<any>>",
description: "Read glossary schema by its name and object type",
params: [
{ name: "glossaryName", type: "string", description: "the glossary schema name" },
Expand All @@ -6668,9 +6668,11 @@ export const helpMetadata: MethodHelpDoc[] = [
{
typeName: "Glossary",
methodName: "readGlossarySchemas",
signature: "readGlossarySchemas(): Promise<GlossarySchemaItemSkeleton<any>[]>",
signature: "readGlossarySchemas( objectType?: GlossaryObjectType ): Promise<GlossarySchemaItemSkeleton<any>[]>",
description: "Read all glossary schemas",
params: [],
params: [
{ name: "objectType", type: "GlossaryObjectType", description: "the glossary schema object type" },
],
returns: "{Promise<GlossarySchemaItemSkeleton[]>} a promise that resolves to an array of glossary schema objects",
},
{
Expand All @@ -6685,8 +6687,8 @@ export const helpMetadata: MethodHelpDoc[] = [
},
{
typeName: "Glossary",
methodName: "exportGlossarySchemaByNameAndObjectType",
signature: "exportGlossarySchemaByNameAndObjectType( glossaryName: string, objectType: GlossaryObjectType ): Promise<GlossarySchemaExportInterface>",
methodName: "exportGlossarySchemaByName",
signature: "exportGlossarySchemaByName( glossaryName: string, objectType?: GlossaryObjectType ): Promise<GlossarySchemaExportInterface>",
description: "Export glossary schema by its name and object type",
params: [
{ name: "glossaryName", type: "string", description: "the glossary schema name" },
Expand All @@ -6697,10 +6699,11 @@ export const helpMetadata: MethodHelpDoc[] = [
{
typeName: "Glossary",
methodName: "exportGlossarySchemas",
signature: "exportGlossarySchemas( options?: GlossarySchemaExportOptions ): Promise<GlossarySchemaExportInterface>",
signature: "exportGlossarySchemas( options?: GlossarySchemaExportOptions, objectType?: GlossaryObjectType ): Promise<GlossarySchemaExportInterface>",
description: "Export all glossary schemas",
params: [
{ name: "options", type: "GlossarySchemaExportOptions", description: "export options" },
{ name: "objectType", type: "GlossaryObjectType", description: "the glossary schema object type" },
],
returns: "{Promise<GlossarySchemaExportInterface>} a promise that resolves to a glossary schema export object",
},
Expand Down Expand Up @@ -6742,8 +6745,8 @@ export const helpMetadata: MethodHelpDoc[] = [
},
{
typeName: "Glossary",
methodName: "deleteGlossarySchemaByNameAndObjectType",
signature: "deleteGlossarySchemaByNameAndObjectType( glossaryName: string, objectType: GlossaryObjectType ): Promise<GlossarySchemaItemSkeleton<any>>",
methodName: "deleteGlossarySchemaByName",
signature: "deleteGlossarySchemaByName( glossaryName: string, objectType?: GlossaryObjectType ): Promise<GlossarySchemaItemSkeleton<any>>",
description: "Delete glossary schema by its name and object type",
params: [
{ name: "glossaryName", type: "string", description: "the glossary schema name" },
Expand All @@ -6754,9 +6757,10 @@ export const helpMetadata: MethodHelpDoc[] = [
{
typeName: "Glossary",
methodName: "deleteGlossarySchemas",
signature: "deleteGlossarySchemas( resultCallback?: ResultCallback<GlossarySchemaItemSkeleton<any>> ): Promise<GlossarySchemaItemSkeleton<any>[]>",
signature: "deleteGlossarySchemas( objectType?: GlossaryObjectType, resultCallback?: ResultCallback<GlossarySchemaItemSkeleton<any>> ): Promise<GlossarySchemaItemSkeleton<any>[]>",
description: "Delete glossary schemas",
params: [
{ name: "objectType", type: "GlossaryObjectType", description: "the glossary schema object type" },
{ name: "resultCallback", type: "ResultCallback", description: "Optional callback to process individual results" },
],
returns: "{Promise<GlossarySchemaItemSkeleton[]>} promise that resolves to an array of glossary schema objects",
Expand Down
8 changes: 4 additions & 4 deletions src/ops/ApplicationOps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ import {
updateCircleOfTrust,
} from './CirclesOfTrustOps';
import {
deleteGlossarySchemaByNameAndObjectType,
exportGlossarySchemaByNameAndObjectType,
deleteGlossarySchemaByName,
exportGlossarySchemaByName,
GlossarySchemaExportInterface,
importGlossarySchemas,
} from './cloud/iga/IgaGlossaryOps';
Expand Down Expand Up @@ -785,7 +785,7 @@ async function exportDependencies({
for (const glossaryName of names) {
exportData = mergeDeep(
exportData,
await exportGlossarySchemaByNameAndObjectType({
await exportGlossarySchemaByName({
glossaryName,
objectType: constants.GLOSSARY_APPLICATION_OBJECT_TYPE,
state,
Expand Down Expand Up @@ -1089,7 +1089,7 @@ async function deleteDependencies({
const names = getGlossarySchemaNames(applicationData);
for (const glossaryName of names) {
try {
await deleteGlossarySchemaByNameAndObjectType({
await deleteGlossarySchemaByName({
glossaryName,
objectType: constants.GLOSSARY_APPLICATION_OBJECT_TYPE,
state,
Expand Down
30 changes: 15 additions & 15 deletions src/ops/cloud/iga/IgaGlossaryOps.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,13 @@ describe('IgaGlossaryOps', () => {
});
});

describe('readGlossarySchemaByNameAndObjectType()', () => {
describe('readGlossarySchemaByName()', () => {
test('0: Method is implemented', async () => {
expect(IgaGlossaryOps.readGlossarySchemaByNameAndObjectType).toBeDefined();
expect(IgaGlossaryOps.readGlossarySchemaByName).toBeDefined();
});

test(`1: Read existing glossary schema by name and objectype`, async () => {
const response = await IgaGlossaryOps.readGlossarySchemaByNameAndObjectType({
const response = await IgaGlossaryOps.readGlossarySchemaByName({
glossaryName: TestData.glossary1.name,
objectType: TestData.glossary1.objectType,
state,
Expand All @@ -121,7 +121,7 @@ describe('IgaGlossaryOps', () => {

test('2: Read non-existing glossary schema with unknown name', async () => {
const unknownName = 'unknownName';
await expect(IgaGlossaryOps.readGlossarySchemaByNameAndObjectType({
await expect(IgaGlossaryOps.readGlossarySchemaByName({
glossaryName: unknownName,
objectType: TestData.glossary1.objectType,
state,
Expand All @@ -130,7 +130,7 @@ describe('IgaGlossaryOps', () => {

test('3: Read non-existing glossary schema with unknown object type', async () => {
const unknownObjectType = 'unknownObjectType';
await expect(IgaGlossaryOps.readGlossarySchemaByNameAndObjectType({
await expect(IgaGlossaryOps.readGlossarySchemaByName({
glossaryName: TestData.glossary1.name,
// @ts-expect-error since we are doing an unknown object type
objectType: unknownObjectType,
Expand Down Expand Up @@ -176,13 +176,13 @@ describe('IgaGlossaryOps', () => {
});
});

describe('exportGlossarySchemaByNameAndObjectType()', () => {
describe('exportGlossarySchemaByName()', () => {
test('0: Method is implemented', async () => {
expect(IgaGlossaryOps.exportGlossarySchemaByNameAndObjectType).toBeDefined();
expect(IgaGlossaryOps.exportGlossarySchemaByName).toBeDefined();
});

test(`1: Export existing glossary schema by name and objectype`, async () => {
const response = await IgaGlossaryOps.exportGlossarySchemaByNameAndObjectType({
const response = await IgaGlossaryOps.exportGlossarySchemaByName({
glossaryName: TestData.glossary1.name,
objectType: TestData.glossary1.objectType,
state,
Expand All @@ -194,7 +194,7 @@ describe('IgaGlossaryOps', () => {

test('2: Export non-existing glossary schema with unknown name', async () => {
const unknownName = 'unknownName';
await expect(IgaGlossaryOps.exportGlossarySchemaByNameAndObjectType({
await expect(IgaGlossaryOps.exportGlossarySchemaByName({
glossaryName: unknownName,
objectType: TestData.glossary1.objectType,
state,
Expand All @@ -203,7 +203,7 @@ describe('IgaGlossaryOps', () => {

test('3: Export non-existing glossary schema with unknown object type', async () => {
const unknownObjectType = 'unknownObjectType';
await expect(IgaGlossaryOps.exportGlossarySchemaByNameAndObjectType({
await expect(IgaGlossaryOps.exportGlossarySchemaByName({
glossaryName: TestData.glossary1.name,
// @ts-expect-error since we are doing an unknown object type
objectType: unknownObjectType,
Expand Down Expand Up @@ -350,13 +350,13 @@ describe('IgaGlossaryOps', () => {
});
});

describe('deleteGlossarySchemaByNameAndObjectType()', () => {
describe('deleteGlossarySchemaByName()', () => {
test('0: Method is implemented', async () => {
expect(IgaGlossaryOps.deleteGlossarySchemaByNameAndObjectType).toBeDefined();
expect(IgaGlossaryOps.deleteGlossarySchemaByName).toBeDefined();
});

test(`1: Delete existing glossary schema by name`, async () => {
const response = await IgaGlossaryOps.deleteGlossarySchemaByNameAndObjectType({
const response = await IgaGlossaryOps.deleteGlossarySchemaByName({
glossaryName: TestData.glossary6.name,
objectType: TestData.glossary6.objectType,
state,
Expand All @@ -366,7 +366,7 @@ describe('IgaGlossaryOps', () => {

test('2: Delete non-existing glossary by unknown name', async () => {
const unknownName = 'unknownName';
await expect(IgaGlossaryOps.deleteGlossarySchemaByNameAndObjectType({
await expect(IgaGlossaryOps.deleteGlossarySchemaByName({
glossaryName: unknownName,
objectType: TestData.glossary1.objectType,
state,
Expand All @@ -375,7 +375,7 @@ describe('IgaGlossaryOps', () => {

test('3: Delete non-existing glossary by unknown object type', async () => {
const unknownObjectType = 'unknownObjectType';
await expect(IgaGlossaryOps.deleteGlossarySchemaByNameAndObjectType({
await expect(IgaGlossaryOps.deleteGlossarySchemaByName({
glossaryName: TestData.glossary1.name,
// @ts-expect-error
objectType: unknownObjectType,
Expand Down
Loading