feat: export getStatus in startupOps. Write test for StartupOps.#49
Open
dallinjsevy wants to merge 3 commits into
Open
feat: export getStatus in startupOps. Write test for StartupOps.#49dallinjsevy wants to merge 3 commits into
dallinjsevy wants to merge 3 commits into
Conversation
phalestrivir
requested changes
Apr 16, 2026
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
Main change that needs to be made is that we'll need to refactor the ESV secrets tests like we did with variables so we can use the same test data for these tests. See comments below.
dallinjsevy
force-pushed
the
feature/push-restart
branch
from
6a0a982 to
f9b7f42
Compare
hfranklin
reviewed
May 22, 2026
| @@ -182,19 +182,17 @@ export async function stageVariable(variable: VariableSkeleton, create = true) { | |||
| // delete if exists, then create | |||
| try { | |||
There was a problem hiding this comment.
@dallinjsevy It looks like Volker made a similar change in commit 260cbd3. Can you resolve the conflict?
Author
There was a problem hiding this comment.
Yes, I'll resolve the conflict today
dallinjsevy
force-pushed
the
feature/push-restart
branch
from
f9b7f42 to
418c185
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.