feat: Add config-manager push connector-mappings command#79
feat: Add config-manager push connector-mappings command#79dallinjsevy wants to merge 6 commits into
Conversation
cc181ee to
a974fab
Compare
801b950 to
19c8063
Compare
There was a problem hiding this comment.
See comments below (there is a bug that needs to be fixed). I also removed some of your test configuration that you included since some of it was client related, plus we only need 2 mappings to test with anyways (I left two in that looked like test mappings that you might've created that would be good for testing with). For the extract_script_test mappings, it looks like you got some scripts already in there, but I would go through the configuration and make sure you have an example of all possible scripts for the mapping to test extraction with since there are several scripts in mappings and it's possible you missed a few (I would probably ask Sean Ku for help creating a good test mapping since he's familiar with what all the possible scripts are that could get extracted). I'm not sure how many scripts config-manager supports extracting, but we'll want to support importing those ones in particular.
e40c115 to
7bd8d12
Compare
4320d96 to
a8667bf
Compare
phalestrivir
left a comment
There was a problem hiding this comment.
A few more changes needed, but everything else looks good
… to run in forgeops
a8667bf to
3267952
Compare
No description provided.