add Deflate from config constructor - #556
Merged
Merged
Conversation
folkertdev
reviewed
Aug 8, 2026
folkertdev
left a comment
folkertdev
left a comment
Member
There was a problem hiding this comment.
Nice, thanks!
Because this is public API and user-facing I'm especially nit-picky here
Comment on lines
308
to
312
| @@ -312,6 +312,20 @@ impl Deflate { | |||
| } | |||
Member
There was a problem hiding this comment.
Can you make this call Self::new_with_config instead?
| /// tweaking `mem_level` or `strategy` is desired. | ||
| /// | ||
| /// This allocates, so should be done with care. | ||
| pub fn new_from_config(config: DeflateConfig) -> Self { |
Member
There was a problem hiding this comment.
Suggested change
| pub fn new_from_config(config: DeflateConfig) -> Self { | |
| pub fn new_with_config(config: DeflateConfig) -> Self { |
| } | ||
| } | ||
|
|
||
| /// Create a new instance from the provided `DeflateConfig`. |
Member
There was a problem hiding this comment.
Suggested change
| /// Create a new instance from the provided `DeflateConfig`. | |
| /// Create a new instance from the provided [`DeflateConfig`]. |
that'll make it clickable
Comment on lines
+317
to
+318
| /// In most cases it is recommended to use the standard `Deflate::new` constructor unless | ||
| /// tweaking `mem_level` or `strategy` is desired. |
Member
There was a problem hiding this comment.
Suggested change
| /// In most cases it is recommended to use the standard `Deflate::new` constructor unless | |
| /// tweaking `mem_level` or `strategy` is desired. | |
| /// In most cases it is recommended to use the standard [`Deflate::new`] constructor unless | |
| /// tweaking `mem_level` or `strategy` is desired. |
Contributor
Author
Totally understand - addressed everything, thanks! |
Contributor
Author
|
Hey @folkertdev, would you mind re-reviewing this? 🙏 |
Member
|
Right, can you rebase and force push? (I had to fix CI) |
Contributor
Author
|
@folkertdev done! |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This diff exposes a new constructor on the
Deflatestruct allowing users to create an instance directly with a setDeflateConfig.I found myself needing this, as I'd like to use
Deflatewith a specificmem_levelset, which I'm unable to do with the current API.