register: positive 'Secrets: none detected' line on clean dry-run#243
Draft
christophergeyer wants to merge 2 commits into
Draft
register: positive 'Secrets: none detected' line on clean dry-run#243christophergeyer wants to merge 2 commits into
christophergeyer wants to merge 2 commits into
Conversation
register --dry-run listed detected secrets but printed nothing when the scan found none, so an operator couldn't tell 'clean' from 'scan didn't run' (both = absence of a warning). Add a positive confirmation line. Surfaced by the Reproducible AI clean-agent smoke test (checklist gate G). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…unchlist Chris: the dry-run secrets confirmation should be a checklist line, not a separate summary line — no clutter, and a line that's ~always green. Adds a receipt-only 'no secrets in published lineage' check to the reproducibility report (register/put only; reproduce omits it — secrets don't bear on reproducibility). Always passes (roar redacts any hits), with a note 'none detected' / 'N redacted'. Removed the two standalone secrets echoes (dry-run + real register); the punchlist carries it in both. Register all-green is now 8/8. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roar register --dry-runlists detected secret types but printed nothing when the scan found none. So an operator can't distinguish "scanned, clean" from "scan didn't run" — both look like the absence of a warning. Checklist gate G of the Reproducible AI smoke test ([4]) needs a positive confirmation that redaction ran.Adds one line:
Secrets: none detectedin the else branch. Test extended to assert it.test_register_cli.pypasses; ruff clean.🤖 Generated with Claude Code