fix(register): carry source_url into artifact metadata for AI-BOM downloadLocation - #239
Merged
Merged
Conversation
…nloadLocation roar register's batch artifact payload (prepare_batch_registration_artifacts) only sent hashes/size/source_type/session_hash, dropping the artifact's source_url. Source-tracked inputs (e.g. an s3:// dataset pulled through the roar proxy) therefore reached GLaaS with a sourceType but no distribution URL, so the CycloneDX AI-BOM could not emit the downloadLocation external reference (capping completeness at 97.5 instead of 100). Fold source_url into the entry's metadata JSON when the artifact carries a valid remote source_type. GLaaS stores input.metadata verbatim and the BOM builder reads metadata.source_url to emit the distribution reference. Note: a live 100 also requires the GLaaS-api staged (registration-session) ingestion that persists sourceType+metadata to be deployed to prod — that handling is on glaas-api main but not yet on the deployed prod image. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
christophergeyer
pushed a commit
that referenced
this pull request
Jul 27, 2026
This was referenced Jul 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
roar register's batch artifact payload (prepare_batch_registration_artifacts) only senthashes,size,source_type, andsession_hash— it dropped the artifact'ssource_url. A source-tracked input (e.g. ans3://dataset pulled through the roar proxy) therefore reached GLaaS with asourceTypebut no distribution URL, so the CycloneDX AI-BOM could not emit thedownloadLocationexternal reference. This capped AI-BOM completeness at 97.5 instead of 100 for otherwise-complete pipelines.Fix
Fold
source_urlinto the artifact entry'smetadataJSON when it carries a valid remotesource_type. GLaaS storesinput.metadataverbatim, and the BOM builder readsmetadata.source_urlto emit thedistributionexternal reference.roar/application/publish/registration.py→prepare_batch_registration_artifacts.s3/gs/https/hf); merges into any existing metadata without clobbering.Verification
s3input now includesmetadata: {"source_url": "s3://…"}alongsidesource_type: "s3".prepare_batch_registration_artifactsemits the metadata for the s3 input during a realroar register.Cross-repo dependency (for a live 100)
This roar change is necessary but not sufficient on its own. The GLaaS-api staged/bearer registration path (
registration-sessions/:id/artifacts/batch) must persistsourceType+metadata. That handling is present on glaas-apimain(artifact.service.tsregisterBatchUnderRegistrationSession) but not yet on the deployed prod image — prod storessourceType: nulland metadata withoutsource_url. A glaas-api prod deploy ofmainis required alongside this fix.Release
Targets
rc/0.4.1(fast-follow). Not published to PyPI yet — used to generate the treqs.ai AI-BOM example on the 0.4.1 rc.