[GCP] Allow configuring multiple signer secret names#572
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
=======================================
Coverage 25.19% 25.19%
=======================================
Files 27 27
Lines 2040 2040
=======================================
Hits 514 514
Misses 1414 1414
Partials 112 112 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AlCutter
force-pushed
the
gcp_multi_signer
branch
8 times, most recently
from
5a00dba to
6740ee0
Compare
mhutchinson
approved these changes
Jun 29, 2026
| @@ -74,5 +74,5 @@ variable "witness_service_account" { | |||
|
|
|||
| variable "witness_secret_name" { | |||
Contributor
There was a problem hiding this comment.
nit: pluralize this for consistency with others?
AlCutter
force-pushed
the
gcp_multi_signer
branch
from
6740ee0 to
d83f0d8
Compare
AlCutter
force-pushed
the
gcp_multi_signer
branch
from
d83f0d8 to
0f7593c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows configuration of multiple secrets to be used by the GCP witness.