refactor(core): consolidate packages into @uppy/core#6370
Open
qxprakash wants to merge 23 commits into
Open
Conversation
partly addresses #6042 This PR merges `@uppy/store-default` into core and re-exports it via export maps from `@uppy/core` This is 1st of the 5 stacked PRs which I'll create to merge `provider-views` , `companion-client` , `utils` and `store-default` into `@uppy/core` the reason for this stacked PRs approach is to make reviewing easier as 4 out of these 5 PRs are purely mechanical i.e. `removing package` -> `copying files` -> `updating imports and exports`. and it invovles changes across lots of files. so it's easier to review if all the changes are related to a single plugin.
see #6351 for more details
…uppy into core-merge-5-type-unification
This PR removes the duplicate companion/provider bridge types (CompanionClientProvider CompanionClientSearchProvider, and the`view: any` escape hatch) and wires the real Provider/ProviderView types directly, now possible since everything lives in `@uppy/core` Net gain in type safety; no behavior change. for more context on the approach see description of #6351
changesets which mention the merged packages which would fail yarn changeset, so replaced those packages with @uppy/core
|
| Name | Type |
|---|---|
| @uppy/angular | Major |
| @uppy/google-photos-picker | Major |
| @uppy/google-drive-picker | Major |
| @uppy/thumbnail-generator | Major |
| @uppy/golden-retriever | Major |
| @uppy/image-generator | Major |
| @uppy/remote-sources | Major |
| @uppy/screen-capture | Major |
| @uppy/google-drive | Major |
| @uppy/image-editor | Major |
| @uppy/transloadit | Major |
| @uppy/components | Major |
| @uppy/compressor | Major |
| @uppy/status-bar | Major |
| @uppy/xhr-upload | Major |
| @uppy/companion | Major |
| @uppy/dashboard | Major |
| @uppy/drag-drop | Major |
| @uppy/facebook | Major |
| @uppy/onedrive | Major |
| @uppy/unsplash | Major |
| @uppy/dropbox | Major |
| @uppy/locales | Patch |
| @uppy/aws-s3 | Major |
| @uppy/svelte | Major |
| @uppy/webcam | Major |
| @uppy/webdav | Major |
| @uppy/audio | Major |
| @uppy/react | Major |
| @uppy/core | Major |
| @uppy/form | Major |
| @uppy/zoom | Major |
| @uppy/box | Major |
| @uppy/tus | Major |
| @uppy/url | Major |
| @uppy/vue | Major |
| uppy | Patch |
| @uppy/drop-target | Major |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Collaborator
Author
|
I'll remove the migration doc before we merge this to main, it's just there for FYI for the reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6042.
Merges
@uppy/utils,@uppy/store-default,@uppy/companion-client, and@uppy/provider-viewsinto@uppy/core, exposed via subpath exports. These packages are removed. This collapses four separately-versioned packages into the one package every plugin already depends on removing duplicate-version bugs, making updates actually reach users, and letting co-dependent types reference each other directly instead of through hand-maintained duplicates.Since this was a massive change so it's was done across 5 PRs
@uppy/store-default→@uppy/core/store-default@uppy/utils→@uppy/core/utils@uppy/companion-client→@uppy/core/companion-client@uppy/provider-views→@uppy/core/provider-viewsCompanionClientProvider/view: anybridge types and typeUnknownProviderPlugin['provider']structurally (Pick of the realProvider/SearchProvider)Breaking (6.0)
Import paths change, e.g.
@uppy/utils→@uppy/core/utils,@uppy/provider-views/css/*→@uppy/core/provider-views/css/*.RequestOptionsmoves to@uppy/core/companion-client;CompanionClientProvider/CompanionClientSearchProviderare removed (use the nativeProvider/SearchProvider). SeeMIGRATION-6.0-merge-into-core.md.