Integrate uppy io by mifi · Pull Request #6330 · transloadit/uppy

mifi · 2026-06-11T19:56:50Z

/packages/uppy.io used to live in its own git repository but I am here moving it into the uppy monorepo workspace.

NOTE: This is best reviewed commit by commit.

TODO (future?)

Review each workflow to ensure env secrets and permissions are set for the monorepo.
eslint/remark/prettier -> biome
move static out of the repo (100+ megabytes)
also probably move out existing large files from the uppy repo
archive/deprecate https://github.com/transloadit/uppy.io

changeset-bot · 2026-06-11T19:56:56Z

⚠️ No Changeset found

Latest commit: 2606116

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

socket-security · 2026-06-11T19:58:52Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	lodash@4.17.23 ⏵ 4.18.1	⁺¹	⁺¹⁸	⁺¹
	chalk@2.4.2 ⏵ 5.3.0	⁺¹		⁺¹

View full report

socket-security · 2026-06-11T19:58:54Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		Obfuscated code: npm `caniuse-lite` is 90.0% likely obfuscated Confidence: 0.90 Location: Package overview From: `?` → `npm/caniuse-lite@1.0.30001793` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/caniuse-lite@1.0.30001793`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		Obfuscated code: npm `caniuse-lite` is 90.0% likely obfuscated Confidence: 0.90 Location: Package overview From: `?` → `npm/caniuse-lite@1.0.30001793` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/caniuse-lite@1.0.30001793`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		Obfuscated code: npm `caniuse-lite` is 90.0% likely obfuscated Confidence: 0.90 Location: Package overview From: `?` → `npm/caniuse-lite@1.0.30001793` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/caniuse-lite@1.0.30001793`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.
Warn		Obfuscated code: npm `caniuse-lite` is 90.0% likely obfuscated Confidence: 0.90 Location: Package overview From: `?` → `npm/caniuse-lite@1.0.30001793` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/caniuse-lite@1.0.30001793`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

mifi · 2026-06-11T20:02:48Z

@copilot why are github actions (e.g. ci tests) not being run?

Copilot · 2026-06-11T20:12:14Z

@copilot why are github actions (e.g. ci tests) not being run?

Looking at the CI workflow configuration and the PR's changed files:

The ci.yml has a paths-ignore filter for pull_request events:

paths-ignore:
  - '**.md'
  - '.github/**'
  - '!.github/workflows/ci.yml'

This PR changes 484 files. Of those, the vast majority are either:

Blog posts / docs under packages/uppy.io/ that are .md / .mdx files → matched by **.md
Files under .github/ → matched by .github/**

The !.github/workflows/ci.yml negation pattern was intended to ensure CI still runs when ci.yml itself is modified. However, since this PR also modifies .github/workflows/deploy-web.yml and .github/dependabot.yml, those are still treated as "ignored".

That said, the PR also changes several files that are not covered by paths-ignore — biome.json, package.json, yarn.lock, and many packages/uppy.io/ config/source files (.eslintrc.js, babel.config.js, .mdx docs, etc.) — which should have triggered CI. The lockfile_check.yml uses paths: - yarn.lock and yarn.lock was changed, so that should have triggered too.

In short, based on the workflow configuration the CI should be triggering. This appears to be a GitHub Actions processing issue, likely related to the unusually large diff size (484 files, 50k+ additions including many static assets). You may want to try pushing an empty commit to re-trigger the pull_request: synchronize event, or close and reopen the PR to fire pull_request: reopened.

On a related note: the PR description already has a TODO to "Review each workflow to ensure env secrets and permissions are set for the monorepo" — once CI does trigger, the new Build website step in the unit_tests job and the new lint_web job will both exercise the uppy-io workspace, so it's worth confirming those pass end-to-end.

qxprakash

I would like to test this locally but for some reason I can't check this branch out locally on my machine it keeps erroring out, but apart from couple of my review comments. I would like to stress on the point which you already made in the PR description which is to move static files out of the repo , I think we should do this before merging this PR to main because once this PR gets merged into main those static files would become part of the git history and every clone would pull those static files.

qxprakash · 2026-06-22T07:09:18Z

+      - name: Build website
+        run: corepack yarn workspace uppy-io build


"Build website" step was added to the unit_tests job ? every CI run will now run a full docusaurus build which deploy-web.yml does already ?

I thought to add it to CI to make sure that it successfully builds, to catch any obvious errors like syntax errors or broken imports (e.g. in PRs because the deploy job does not run in PRs)

qxprakash · 2026-06-22T07:11:01Z

+on:
+  workflow_dispatch:
+  push:
+    branches:
+      - main
+    # Review gh actions docs if you want to further define triggers, paths, etc
+    # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#on
+
+env:
+  NODE_VERSION: lts/*
+
+permissions:
+  contents: read
+  id-token: write
+  pages: write
+
+concurrency:
+  group: github-pages
+  cancel-in-progress: false
+
+jobs:


shouldn't we have a path filter here ? so that it only runs with changes to packages/uppy.io/** and not on every push to main ?

I thought about it, but uppy.io depends on @uppy/react, which again depends on

"@uppy/core": "workspace:^", "@uppy/dashboard": "workspace:^", "@uppy/screen-capture": "workspace:^", "@uppy/status-bar": "workspace:^", "@uppy/webcam": "workspace:^",

and at this point, maybe we should just build it all the time?

mifi added 6 commits June 11, 2026 13:43

move uppy.io files into workspace (except static)

260611d

add static files

2606118

add monorepo

260611c

remove yarn stuff

2606118

yarn

2606115

integrate uppy.io into uppy

2606116

Copilot started work on behalf of mifi June 11, 2026 20:03 View session

Copilot finished work on behalf of mifi June 11, 2026 20:12

mifi requested a review from qxprakash June 11, 2026 21:09

qxprakash requested changes Jun 22, 2026

View reviewed changes

qxprakash assigned mifi Jun 22, 2026

mifi mentioned this pull request Jun 23, 2026

@uppy/aws-s3: issue tracker #6229

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Integrate uppy io#6330

Integrate uppy io#6330
mifi wants to merge 6 commits into
mainfrom
integrate-uppy-io

mifi commented Jun 11, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jun 11, 2026

Uh oh!

socket-security Bot commented Jun 11, 2026

Uh oh!

socket-security Bot commented Jun 11, 2026

Uh oh!

mifi commented Jun 11, 2026

Uh oh!

Copilot AI commented Jun 11, 2026

Uh oh!

qxprakash left a comment •

edited

Loading

Uh oh!

qxprakash Jun 22, 2026

Uh oh!

mifi Jun 23, 2026

Uh oh!

qxprakash Jun 22, 2026

Uh oh!

mifi Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		- name: Build website
		run: corepack yarn workspace uppy-io build

Uh oh!

Conversation

mifi commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jun 11, 2026

⚠️ No Changeset found

Uh oh!

socket-security Bot commented Jun 11, 2026

Uh oh!

socket-security Bot commented Jun 11, 2026

Uh oh!

mifi commented Jun 11, 2026

Uh oh!

Copilot AI commented Jun 11, 2026

Uh oh!

qxprakash left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qxprakash Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

mifi Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

qxprakash Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

mifi Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mifi commented Jun 11, 2026 •

edited

Loading

qxprakash left a comment •

edited

Loading