Skip to content

Preserve emitted Assembly metadata and future response errors - #540

Merged
kvz merged 3 commits into
mainfrom
status-readers
Oct 8, 2026
Merged

kvz merged 3 commits into
mainfrom
status-readers

Conversation

@kvz

@kvz kvz commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

The SDK currently rejects valid Assembly responses already emitted by API2: numeric State/XPSubject, repeated date tags and null upload extensions. A closed response-error enum also rejects future server errors. Correct those readers and exported response types in a separate breaking PR, as Kevin requested, instead of hiding a type break inside the patch alphalib sync.

Merged after #539, with this PR retargeted to main and current main merged before the final green CI run.

  • Preserve finite numeric metadata and mixed repeated date values without coercion; reject booleans, nonfinite numbers and nested arrays.
  • Accept nullable completed-upload extensions and nonempty future response errors in status and list APIs. Keep the 371-code known inventory closed.
  • Recognize future terminal errors while retaining busy/success states with explicit undefined errors. Preserve known-code autocomplete in hasError while allowing future codes.
  • Include majors for node, transloadit, types and zod, and pre-1.0 minors for MCP and the notification relay (which publicly exports the same AssemblyResponse type). The migration guide describes the widened fields and required narrowing. The approved release was published through Version Packages #544: node, transloadit, types and zod 6.0.0; MCP 0.6.0; notification relay 0.3.0. All six npm versions and latest dist-tags, matching Git tags, published GitHub Releases and final main CI are verified.

Validation: the actual SDK HTTP response fixture first failed 13 cases; the focused response/lean suites now pass 123 tests. Review exposed four busy/success classification regressions, demonstrated red and fixed green. TypeScript's language service demonstrated missing known-code suggestions before the correction and now suggests all 371 codes. Full SDK check/verify chains, Zod v3/v4 runtime parity and public declaration equality, clean-output generators, dependency/publish guards and package parity pass. Packed entry points, manifest and file inventory stay identical to the sync parent; changes are confined to Assembly Status source and compiled declarations/runtime/maps. Node 20.10 support remains unchanged.

@kvz
kvz marked this pull request as ready for review October 8, 2026 00:16
@kvz
kvz requested a review from tim-kos October 8, 2026 00:16
@kvz kvz self-assigned this Oct 8, 2026
Base automatically changed from alphalib-261007 to main October 8, 2026 06:00
@kvz
kvz merged commit 3b4db64 into main Oct 8, 2026
14 checks passed
@kvz
kvz deleted the status-readers branch October 8, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant