Repository navigation
Preserve emitted Assembly metadata and future response errors - #540
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK currently rejects valid Assembly responses already emitted by API2: numeric State/XPSubject, repeated date tags and null upload extensions. A closed response-error enum also rejects future server errors. Correct those readers and exported response types in a separate breaking PR, as Kevin requested, instead of hiding a type break inside the patch alphalib sync.
Merged after #539, with this PR retargeted to main and current main merged before the final green CI run.
hasErrorwhile allowing future codes.Validation: the actual SDK HTTP response fixture first failed 13 cases; the focused response/lean suites now pass 123 tests. Review exposed four busy/success classification regressions, demonstrated red and fixed green. TypeScript's language service demonstrated missing known-code suggestions before the correction and now suggests all 371 codes. Full SDK check/verify chains, Zod v3/v4 runtime parity and public declaration equality, clean-output generators, dependency/publish guards and package parity pass. Packed entry points, manifest and file inventory stay identical to the sync parent; changes are confined to Assembly Status source and compiled declarations/runtime/maps. Node 20.10 support remains unchanged.