Remove unnecessary boxfutures#3525
Merged
Merged
Conversation
joeydewaal
marked this pull request as draft
September 26, 2024 09:44
Contributor
Author
|
It seems like the stack is overflowing in debug mode, in release mode the tests pass. |
joeydewaal
marked this pull request as ready for review
September 26, 2024 11:06
Collaborator
|
We probably need to do the same thing to |
Collaborator
|
The |
Contributor
Author
I opened a new pr for this (#3529) |
joeydewaal
force-pushed
the
remove_boxfutures
branch
3 times, most recently
from
October 9, 2024 20:15
95f6986 to
257d869
Compare
joeydewaal
force-pushed
the
remove_boxfutures
branch
from
July 2, 2025 08:47
00cff28 to
eca26ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change
This pr removes unnecessary
BoxFuture's in trait definitionsConnection,MigrateDatabase,TransactionManager,ConnectOptions,TestSupportandPgPoolCopyExt.I was not able to make these changes to the
ExecutorandAcquiretraits unfortunately because of a rustc limitation.