chore: rename module path to github.com/traefik/assimilis/v2#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Renames the Go module from
github.com/traefik/assimilistogithub.com/traefik/assimilis/v2so that v2.x tags can be resolved bygo installandgo get.Motivation
With a v2 tag, Go's semantic import versioning requires the module path to end in
/v2. Without that suffix,go install github.com/traefik/assimilis/cmd/assimilis@v2.0.1fails withinvalid version: module contains a go.mod file, so module path must match major version. Downstream consumers (traefik/traefik, traefik/traefikee) had to pin a commit SHA instead of the tag.Updates
go.mod, the two internal imports incmd/assimilis/, the test file, theMakefileLDFLAGS prefix and the goreleaser ldflags.Additional Notes
v2.0.1cannot be reused — a new tag (e.g.v2.0.2) must be cut after merge, then downstream pins bumped to@v2.0.2.