refactor(useControlledState): use ref to store latest onChange handle…#283
Open
kyukyu-dev wants to merge 1 commit intotoss:mainfrom
Open
refactor(useControlledState): use ref to store latest onChange handle…#283kyukyu-dev wants to merge 1 commit intotoss:mainfrom
kyukyu-dev wants to merge 1 commit intotoss:mainfrom
Conversation
…r and prevent stale closure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r and prevent stale closure
Overview
This PR refactors
useControlledStateto improve internal stability and prevent stale closures.onChangecallback in a ref (onChangeRef).useInsertionEffect(oruseLayoutEffectas a fallback) to synchronize the ref update before layout effects.setValueand removeonChangefrom dependency arrays to avoid unnecessary re-renders.This change aligns the hook's behavior with React 18's Strict Mode and concurrent rendering patterns.
Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?