refactor: replace any with safer type for package.json rewrite#10
Open
refactor: replace any with safer type for package.json rewrite#10
any with safer type for package.json rewrite#10Conversation
|
@gwagjiug is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced the use of
anyin therewritefunction ofloadConfigwith a safer type definition:PackageJson & Record<string, unknown>.Details
pkgwas typed asany, which bypassed TypeScript's type checking and could lead to unsafe property access.PackageJson & Record<string, unknown>:PackageJsonprovides type safety for standardpackage.jsonfields.Record<string, unknown>allows custom fields to be safely accessed.Why
This change removes unsafe
anyusage while keeping compatibility with user-defined fields inpackage.json, ensuring more reliable type checks and better developer experience.