fix: add sleep after HTTP server stop in health check test to avoid race condition#1661
Closed
josecelano wants to merge 2 commits intotorrust:developfrom
Closed
fix: add sleep after HTTP server stop in health check test to avoid race condition#1661josecelano wants to merge 2 commits intotorrust:developfrom
josecelano wants to merge 2 commits intotorrust:developfrom
Conversation
Member
Author
|
ACK 2d65b09 |
Member
Author
|
The testing workflow failed in this PR. |
1 similar comment
Member
Author
|
The testing workflow failed in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1661 +/- ##
===========================================
- Coverage 86.47% 86.42% -0.05%
===========================================
Files 288 288
Lines 22672 22672
Branches 22672 22672
===========================================
- Hits 19605 19594 -11
- Misses 2839 2846 +7
- Partials 228 232 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
it_should_return_error_when_http_service_was_stopped_after_registrationwas flaky on nightly Rust because the OS can keep a TCP port inCLOSE_WAIT/TIME_WAITbriefly after the server stops, causing the health check to still returnOkinstead ofError.\n\nAdds a 100ms sleep afterstop().awaitto let the OS fully release the TCP port before the health check runs.