Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| AND m."homeCountryCode" IS NOT NULL | ||
| AND ($1::text IS NULL OR COALESCE(m."homeCountryCode", m."competitionCountryCode") = $1) | ||
| AND ($3::uuid[] IS NULL OR ms.skill_ids && $3::uuid[]) | ||
| AND ($3::uuid[] IS NULL OR ms.skill_ids @> $3::uuid[]) |
There was a problem hiding this comment.
[❗❗ correctness]
The change from && to @> alters the logic from checking for any overlap to ensuring all elements in $3 are present in ms.skill_ids. Ensure this change aligns with the intended logic for filtering by skills, as it could significantly impact the query results.
| AND m."homeCountryCode" IS NOT NULL | ||
| AND ($1::text IS NULL OR COALESCE(m."homeCountryCode", m."competitionCountryCode") = $1) | ||
| AND ($5::uuid[] IS NULL OR ms.skill_ids && $5::uuid[]) | ||
| AND ($5::uuid[] IS NULL OR ms.skill_ids @> $5::uuid[]) |
There was a problem hiding this comment.
[❗❗ correctness]
The change from && to @> modifies the logic from checking for any overlap between ms.skill_ids and $5 to ensuring ms.skill_ids contains all elements of $5. Ensure this change aligns with the intended behavior of the skills filter, as it could significantly alter the query results.
kkartunov
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-4203