Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| queryParams.set('openToWork', 'false') | ||
| } | ||
|
|
||
| if (Array.isArray(skillIds) && skillIds.length > 0) { |
There was a problem hiding this comment.
[💡 maintainability]
Consider using skillIds.filter(Boolean) to remove falsy values before iterating. This simplifies the code by eliminating the need for the if (id) check inside the loop.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
...customer-portal/src/pages/profile-completion/ProfileCompletionPage/ProfileCompletionPage.tsx
Show resolved
Hide resolved
| value: String(skill.id), | ||
| })) | ||
| .filter((option: InputMultiselectOption) => !!option.value) | ||
| } catch { |
There was a problem hiding this comment.
[correctness]
Filtering options with !!option.value might not be sufficient if value can be a falsy but valid value (e.g., 0). Ensure that this filtering logic aligns with the expected data structure.
...customer-portal/src/pages/profile-completion/ProfileCompletionPage/ProfileCompletionPage.tsx
Show resolved
Hide resolved
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
...customer-portal/src/pages/profile-completion/ProfileCompletionPage/ProfileCompletionPage.tsx
Show resolved
Hide resolved
@kkartunov This is fixed now. Can you please review the backend PR related to this one? topcoder-platform/reports-api-v6#63 |
2 participants
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-4203
What's in this PR?