Fix: Address feedbacks in https://github.com/melpa/melpa/pull/10028#378
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f807526221
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (if-let* ((session (ai-code-session-dashboard--session-at-point)) | ||
| (repo-root (ai-code-session-repo-root session))) | ||
| (magit-status repo-root) | ||
| (magit-status-setup-buffer repo-root) |
There was a problem hiding this comment.
When users run with the package's declared minimum dependency, Package-Requires: ... (magit "2.1.0"), pressing D in the session dashboard now calls magit-status-setup-buffer, but Magit 2.1 exposes magit-status-internal as the noninteractive helper instead and does not define this function. In that supported environment this path signals void-function instead of opening the repository status; either keep using the public magit-status wrapper or raise/guard the Magit minimum version.
Useful? React with 👍 / 👎.
This reverts commit 052de6a.
1 participant
No description provided.