Repository navigation
Run test/soundness_tests in dune runtest - #307
Merged
Merged
Conversation
When the `.tla` tests were moved to dune, only `TOOLS/do_tests` got a `runtest` rule, so `make test` and CI never ran the soundness tests (`*_stest.tla`). Add a second rule for `TOOLS/do_soundness_tests`, mirroring the one for `do_tests`, and make the runner exit with a non-zero status if any soundness test fails; it used to always exit with 0. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
`do_soundness_tests` put its JUnit scratch file in /var/tmp but all its other temporary files in /tmp. Where /var/tmp is not writable, every `tee` to it failed with "Permission denied". Use /tmp for it as well. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
lemmy
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The soundness tests (
test/soundness_tests/*_stest.tla) pass only if their obligation is not proved. They have their own runner,test/TOOLS/do_soundness_tests, but when the .tla tests moved to dune, the soundness tests where omitted. As a result, neithermake testnor CI has been running them./var/tmpto/tmp, which removes the "Permission denied" noise where/var/tmpisn't writable