fix: accept .svn directories in repo root validation#456
Open
zxyDEDIRE wants to merge 1 commit intotirth8205:mainfrom
Open
fix: accept .svn directories in repo root validation#456zxyDEDIRE wants to merge 1 commit intotirth8205:mainfrom
zxyDEDIRE wants to merge 1 commit intotirth8205:mainfrom
Conversation
The repo root validation in _validate_repo_root() and related functions only checked for .git and .code-review-graph directories. This caused all MCP tools to reject SVN working copies at the validation gate, even though the core SVN support (incremental.py, changes.py) was already implemented in v2.3.3 via PR tirth8205#255. Add .svn directory checks to: - tools/_common.py:_validate_repo_root() (MCP tool entry point) - daemon.py (daemon skip logic and register validation) - registry.py (register command validation) Co-Authored-By: Claude Opus 4.7 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo root validation in _validate_repo_root() and related functions only checked for .git and .code-review-graph directories. This caused all MCP tools to reject SVN working copies at the validation gate, even though the core SVN support (incremental.py, changes.py) was already implemented in v2.3.3 via PR #255.
Add .svn directory checks to: