Skip to content

fix(flows): default require_approval to false for builder-created workflows (frontend paths)#4668

Merged
graycyrus merged 1 commit into
tinyhumansai:mainfrom
graycyrus:fix/flows-approval-default-false
Jul 7, 2026
Merged

fix(flows): default require_approval to false for builder-created workflows (frontend paths)#4668
graycyrus merged 1 commit into
tinyhumansai:mainfrom
graycyrus:fix/flows-approval-default-false

Conversation

@graycyrus

Copy link
Copy Markdown
Contributor

The minimal fix (replaces the over-scoped #4667). Keeps the require_approval concept intact — just flips the default to false so builder-created flows don't ship approval-on and deadlock.

Why flows still parked despite B3

B3 (#4651) defaulted require_approval=false in the propose/revise tools + the server RPC — but two frontend paths still forced true, so the flow persisted require_approval=1 and parked on its first outbound tool (a Run-button/scheduled run has no thread_id/client_id, so the approval card can't surface → deadlock).

Fix (2 lines + tests)

  • WorkflowPromptBar.tsx — the "describe a workflow" blank-flow create passed true to createFlow → now false.
  • ChatRuntimeProvider.tsxparseWorkflowProposal mapped require_approval !== false (defaulted true when absent) → now === true (defaults false, in lockstep with the server). A proposal only requires approval if the builder explicitly set it.

The field / column / gate / UI toggle are all untouched — a user can still enable approval per-flow.

Verification

typecheck clean · WorkflowPromptBar + ChatRuntimeProvider tests updated + green.

…kflows (frontend)

B3 (tinyhumansai#4651) defaulted require_approval=false in the propose/revise tools + the server
RPC, but two FRONTEND paths still forced it true, so builder-created flows persisted
require_approval=1 and deadlocked on their first outbound tool (no thread/client to
surface the approval card):

- WorkflowPromptBar.tsx: the "describe a workflow" blank-flow create passed `true` to
  createFlow → now `false`.
- ChatRuntimeProvider.tsx: parseWorkflowProposal mapped `require_approval !== false`
  (i.e. defaulted true when absent) → now `=== true` (defaults false, matching the
  server). A proposal only requires approval if the builder EXPLICITLY set it.

The require_approval concept/field/column/gate/UI are all kept intact — this only flips
the DEFAULT so flows don't ship approval-on-by-default. Users can still turn it on.

typecheck clean; WorkflowPromptBar + ChatRuntimeProvider tests updated + green.
@graycyrus graycyrus requested a review from a team July 7, 2026 19:36
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33e12d66-e663-414e-834e-f581842bd699

📥 Commits

Reviewing files that changed from the base of the PR and between cd0b08e and 6d94c56.

📒 Files selected for processing (3)
  • app/src/components/flows/WorkflowPromptBar.test.tsx
  • app/src/components/flows/WorkflowPromptBar.tsx
  • app/src/providers/ChatRuntimeProvider.tsx

Comment @coderabbitai help to get the list of available commands.

@graycyrus graycyrus merged commit 8018eeb into tinyhumansai:main Jul 7, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant