fix(flows): default require_approval to false for builder-created workflows (frontend paths)#4668
Conversation
…kflows (frontend) B3 (tinyhumansai#4651) defaulted require_approval=false in the propose/revise tools + the server RPC, but two FRONTEND paths still forced it true, so builder-created flows persisted require_approval=1 and deadlocked on their first outbound tool (no thread/client to surface the approval card): - WorkflowPromptBar.tsx: the "describe a workflow" blank-flow create passed `true` to createFlow → now `false`. - ChatRuntimeProvider.tsx: parseWorkflowProposal mapped `require_approval !== false` (i.e. defaulted true when absent) → now `=== true` (defaults false, matching the server). A proposal only requires approval if the builder EXPLICITLY set it. The require_approval concept/field/column/gate/UI are all kept intact — this only flips the DEFAULT so flows don't ship approval-on-by-default. Users can still turn it on. typecheck clean; WorkflowPromptBar + ChatRuntimeProvider tests updated + green.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
The minimal fix (replaces the over-scoped #4667). Keeps the
require_approvalconcept intact — just flips the default to false so builder-created flows don't ship approval-on and deadlock.Why flows still parked despite B3
B3 (#4651) defaulted
require_approval=falsein the propose/revise tools + the server RPC — but two frontend paths still forcedtrue, so the flow persistedrequire_approval=1and parked on its first outbound tool (a Run-button/scheduled run has nothread_id/client_id, so the approval card can't surface → deadlock).Fix (2 lines + tests)
WorkflowPromptBar.tsx— the "describe a workflow" blank-flow create passedtruetocreateFlow→ nowfalse.ChatRuntimeProvider.tsx—parseWorkflowProposalmappedrequire_approval !== false(defaulted true when absent) → now=== true(defaults false, in lockstep with the server). A proposal only requires approval if the builder explicitly set it.The field / column / gate / UI toggle are all untouched — a user can still enable approval per-flow.
Verification
typecheckclean ·WorkflowPromptBar+ChatRuntimeProvidertests updated + green.