Omarchy shell migration prep and menu selector compatibility#12
Draft
timmo001 wants to merge 6 commits into
Draft
Omarchy shell migration prep and menu selector compatibility#12timmo001 wants to merge 6 commits into
timmo001 wants to merge 6 commits into
Conversation
- Extract RequiredUserUnitSetup interface and checkRequiredUserUnitSetup generic helper to consolidate checkDoctorStartup and checkResumeMonitor - Add USER_SYSTEMD_DIR, userSystemdUnitPath(), and script path constants - Inline single-use run_resume_recovery() in on-resume-monitor - Reuse userSystemdUnitPath in daily volume reset check No behaviour change; all check messages, severities, and guidance preserved.
Add menu_select() helper to twitch-menu, workspace-menu, and workspace-relayout that prefers omarchy-menu-select (args-based) and falls back to omarchy-launch-walker --dmenu. - Options passed as positional args for Omarchy 3 and 4 compatibility - Prompts omit trailing ellipsis (omarchy-menu-select appends its own) - Walker fallback still appends ellipsis in the prompt flag - workspace-relayout adds menu_selector_available() guard and uses a generic missing-selector notification instead of Walker-specific one Prepares these scripts for Omarchy 4 Quickshell migration where omarchy-menu-select becomes shell-IPC-backed instead of Walker-backed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares shell scripts for the Omarchy 4 Quickshell migration by abstracting menu selection behind a compatibility helper, refactoring duplicated systemd doctor checks, and adding a dbus-based resume monitor.
Supersedes PR #11 (closed).
Commits
on-resumescript with shell indicator refresh, migration plan docson-resume-monitor), systemd user servicedot-migration/omarchy-quickshell/README.mdchecklistcheckRequiredUserUnitSetupgeneric, constants, inlinedrun_resume_recovery()menu_select()helper intwitch-menu,workspace-menu,workspace-relayoutMenu Selector Compatibility
Added
menu_select()helper to three scripts that:omarchy-menu-selectwith positional args (works on Omarchy 3 Walker-backed and Omarchy 4 shell-IPC-backed versions)omarchy-launch-walker --dmenufor environments withoutomarchy-menu-selectomarchy-menu-selectappends its own)workspace-relayoutalso adds amenu_selector_available()guard and generic error notification.Doctor Check Refactor
RequiredUserUnitSetupinterface andcheckRequiredUserUnitSetupgeneric helpercheckDoctorStartupandcheckResumeMonitorinto declarative config objectsUSER_SYSTEMD_DIR,userSystemdUnitPath(),DOCTOR_STARTUP_NOTIFY_SCRIPT,RESUME_MONITOR_SCRIPTValidation
bash -npasses on all modified shell scriptsbunx tsc --noEmitpassesbun run buildpassesbun run formatapplied (no unformatted code)Context
This is prep work for the Omarchy 4 Quickshell migration. On Omarchy 3,
omarchy-menu-selectis Walker-backed and requires ≥2 args. Omarchy 4 replaces it with a shell-IPC-backed version that also accepts stdin. By abstracting behindmenu_select(), these scripts will work on both versions without modification when the shell migration happens.