Skip to content

Add support to AGP 7.3.0 - #12

Open
extmkv wants to merge 11 commits into
timfreiheit:masterfrom
extmkv:master
Open

Add support to AGP 7.3.0#12
extmkv wants to merge 11 commits into
timfreiheit:masterfrom
extmkv:master

Conversation

@extmkv

@extmkv extmkv commented Dec 20, 2022

Copy link
Copy Markdown

Adding support to AGP 7.3.0.

scrDirectory needs to be added to the variants from the new Variant API.

Resolves #10, resolves #11

@jakubjerabek

Copy link
Copy Markdown

Good job @extmkv. We are facing the same issue as you. I hope that @timfreiheit will be able to process this pull request. Thank you.

@extmkv

extmkv commented Jan 17, 2023

Copy link
Copy Markdown
Author

@jakubjerabek I've publish my fork on Gradle Plugins, you can include it and test it in your side.

https://plugins.gradle.org/plugin/pt.jcosta.resourceplaceholders

@jakubjerabek

Copy link
Copy Markdown

@jakubjerabek I've publish my fork on Gradle Plugins, you can include it and test it in your side.

https://plugins.gradle.org/plugin/pt.jcosta.resourceplaceholders

@extmkv Unfortunately my test with your new lib failed (still same behavior). I've contacted you via e-mail from your github profile with details, did you get it? Thank you.

@extmkv

extmkv commented Jan 24, 2023

Copy link
Copy Markdown
Author

Which version of AGP are you using in your project?

@jakubjerabek

Copy link
Copy Markdown

We are using 7.3.1.

@extmkv

extmkv commented Feb 2, 2023

Copy link
Copy Markdown
Author

@jakubjerabek I've update the plugin to use kotlin 1.8 and AGP 7.4.1
Can you try to bump to version 0.6 and also update AGP and kotlin in your side?

@jakubjerabek

Copy link
Copy Markdown

@extmkv Awesome, it works like a charm again. Thank you so much!

@extmkv

extmkv commented Feb 2, 2023

Copy link
Copy Markdown
Author

Great

@t1u1 t1u1 mentioned this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for AGP 7.3.0+ Not working on AGP 7.3.0.

3 participants