[pull] develop from ossrs:develop#59
Merged
Merged
Conversation
…4470) WebRTC RTC publish streams use timer callbacks (`SrsRtcPublishRtcpTimer` and `SrsRtcPublishTwccTimer`) that can cause race conditions in SRS's coroutine-based architecture. The timer callbacks are heavy functions that may trigger coroutine switches, during which the timer object can be freed by another coroutine, leading to use-after-free crashes. The race condition occurs because: 1. Timer callbacks (`on_timer`) perform heavy operations that can yield control 2. During coroutine switches, other coroutines may destroy the timer object 3. When control returns, the callback continues executing on a freed object Fixes potential crashes in WebRTC RTC publish streams under high concurrency.
This PR modernizes SRS's HTTP handling by upgrading from the legacy http-parser library to the more performant and actively maintained llhttp library. * Replace http-parser with llhttp: Migrated from the deprecated http-parser to llhttp for better performance and maintenance * API compatibility: Updated all HTTP parsing logic to use llhttp APIs while maintaining backward compatibility * Simplified URL parsing: Replaced complex http-parser URL parsing with custom simple parser implementation Enhanced error handling: Improved error reporting with llhttp's better error context and positioning --------- Co-authored-by: OSSRS-AI <winlinam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )