Prevent non-leader party members from using zone transition doors (#845)#865
Open
sfedev wants to merge 1 commit into
Open
Prevent non-leader party members from using zone transition doors (#845)#865sfedev wants to merge 1 commit into
sfedev wants to merge 1 commit into
Conversation
…ltedphoques#845) When the local player is in a party but is not the leader, block load door activations (Door + ExtraTeleport) and show a system message pointing the user at the party menu teleport. Leader activations, solo play, non-party contexts, NPC/script activations, and in-cell doors (which lack ExtraTeleport) are untouched. Scope note: this is the minimal "always block" interpretation. The issue's richer "door unlocks for followers once the leader passes through" mechanic is deferred, since it needs per-door state synced across the party and is worth its own PR. Known trade-off: a quest script that calls `player.Activate(loadDoor)` directly will also be blocked for non-leaders. This path is rare in practice; if it surfaces, a per-quest exclusion list (mirroring QuestService's kNonSyncableQuestIds) is the natural follow-up.
Collaborator
|
What about the caves and other means of entering locations? Also
needs to be a localizable string. As I already commented on #845, we should really just prioritize fixing robustness of the existing actor management system. This change makes the game very restrictive (although maybe for good), I'd like to hear more opinions on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the local player is in a party but is not the leader, block load door activations (Door + ExtraTeleport) and show a system message pointing the user at the party menu teleport. Leader activations, solo play, non-party contexts, NPC/script activations, and in-cell doors (which lack ExtraTeleport) are untouched.
Scope note: this is the minimal "always block" interpretation. The issue's richer "door unlocks for followers once the leader passes through" mechanic is deferred, since it needs per-door state synced across the party and is worth its own PR.
Known trade-off: a quest script that calls
player.Activate(loadDoor)directly will also be blocked for non-leaders. This path is rare in practice; if it surfaces, a per-quest exclusion list (mirroring QuestService's kNonSyncableQuestIds) is the natural follow-up.