Skip to content

fix(mcp): auto-OAuth on server add#446

Open
nori-sessions[bot] wants to merge 2 commits intomainfrom
fix-mcp-auto-oauth
Open

fix(mcp): auto-OAuth on server add#446
nori-sessions[bot] wants to merge 2 commits intomainfrom
fix-mcp-auto-oauth

Conversation

@nori-sessions
Copy link
Copy Markdown

@nori-sessions nori-sessions bot commented Apr 18, 2026

Summary

🤖 Generated with Nori

  • Fix persist_mcp_servers to sync in-memory Config.mcp_servers after writing to disk, so ComputeMcpAuthStatuses sees newly added servers
  • Add set_mcp_servers() setter on ChatWidget following the existing pattern of set_approval_policy, set_vim_mode, etc.
  • This enables the existing auto-OAuth trigger to fire when a user adds an HTTP MCP server without a bearer token

Test Plan

  • Added unit test verifying set_mcp_servers updates config_ref()
  • Existing picker-level auto-probe tests pass (auto_probe_triggers_oauth_for_not_logged_in_server, etc.)
  • Full nori-tui test suite passes (1200 tests)
  • Clippy clean

Share Nori with your team: https://www.npmjs.com/package/nori-skillsets

persist_mcp_servers wrote to disk but never updated the in-memory
Config.mcp_servers, so ComputeMcpAuthStatuses read stale config and
the auto-OAuth trigger never fired for newly added servers.
🤖 Generated with [Nori](https://noriagentic.com)

Co-Authored-By: Nori <contact@tilework.tech>
🤖 Generated with [Nori](https://noriagentic.com)

Co-Authored-By: Nori <contact@tilework.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant