fix(mcp): inject stored OAuth tokens into ACP agent MCP servers#445
Merged
fix(mcp): inject stored OAuth tokens into ACP agent MCP servers#445
Conversation
OAuth tokens stored via browser login (keyring or .credentials.json) were never loaded when converting MCP server configs to SACP protocol types. The agent received HTTP MCP servers with no Authorization header, causing it to report having no MCP tools even after successful OAuth login. - Load stored OAuth tokens as fallback when no bearer_token_env_var is set - Filter out disabled MCP servers (enabled == false) from SACP conversion - Change DCR client name from "Codex" to "Nori" for OAuth login pages - Change keyring service name to "Nori TUI MCP Credentials" - Export load_oauth_tokens from rmcp-client for cross-crate use - Warn when injecting an expired OAuth token 🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <[email protected]>
🤖 Generated with [Nori](https://noriagentic.com) Co-Authored-By: Nori <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
.credentials.json) are now loaded and injected asAuthorization: Bearerheaders when converting MCP server configs to SACP protocol types. Previously onlybearer_token_env_varwas checked — tokens from OAuth login were stored but never sent to the agent.enabled == falseare now filtered out of the SACP conversion instead of being sent to the agent.Test Plan
http_server_with_stored_oauth_tokens_gets_auth_header)bearer_token_env_var_takes_precedence_over_stored_oauth)disabled_servers_are_excluded)/mcppicker renders, HTTP server can be added, config is persisted toconfig.tomlShare Nori with your team: https://www.npmjs.com/package/nori-skillsets