This repository was archived by the owner on Apr 4, 2019. It is now read-only.
Add temporary workaround for SimpleDOM#425
Open
chancancode wants to merge 1 commit intotildeio:masterfrom
Open
Add temporary workaround for SimpleDOM#425chancancode wants to merge 1 commit intotildeio:masterfrom
chancancode wants to merge 1 commit intotildeio:masterfrom
Conversation
Member
Author
|
@krisselden @wycats can you take a look? 👀 |
chancancode
force-pushed
the
simple-dom-compat
branch
3 times, most recently
from
20a565a to
f8b221d
Compare
The current parseHTML implementation requires some DOM APIs not implemented in SimpleDOM. This commit adds a temporary workaround to support using SimpleDOM on the server. In the future, we will move towards using `insertAdjacentHTML` and `innerHTML=` as the main APIs and remove the need of `parseHTML` altogether. This commit also reverts a previous commit that introduced the `setMorphHTML` method, which does exactly what `Morph#setHTML` does.
chancancode
force-pushed
the
simple-dom-compat
branch
from
f8b221d to
6021b45
Compare
|
Hey, what's the status of this? :) @chancancode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires krisselden/morph-range#8
The current parseHTML implementation requires some DOM APIs not implemented in SimpleDOM. This commit adds a temporary workaround to support using SimpleDOM on the server.
In the future, we will move towards using
insertAdjacentHTMLandinnerHTML=as the main APIs and remove the need ofparseHTMLaltogether.This commit also reverts a previous commit that introduced the
setMorphHTMLmethod, which does exactly whatMorph#setHTMLdoes.(I added a test, but it's not currently running because we disabled all the node tests since #359... @stefanpenner ? Anyhow, this particular change is very easy to verify by 👀, so it's not critical to re-enable them just to merge this PR.)