Repository navigation
correct index expiry after a session ttl and fold stop words by charset - #162
Merged
Merged
Conversation
a row given an expiry by a session ttl in a table with no ttl of its own kept that expiry on its unchanged index entries when a later update cleared it, so the index lost the row while it still existed. the first such write now records a marker in the table, loaded at open, and from then on every update rewrites the row's index entries with its current expiry, also after a restart. stop words read from a stop word table are lowercased with utf8mb4 case rules rather than ascii only, so an uppercase word outside ascii matches the lowercased text. stale comments on single deletes, bulk batching, value log metering and plugin init now match the code, and the manual and its partitioning example are updated to match
…its own write the stop word fold used utf8mb4_general_ci, which the server does not export to plugins on windows, so the plugin failed to link there. it now uses utf8mb4_bin, which is exported and folds case with the same tables. the session ttl test gave rows four seconds and then restarted the server, which on a slow runner outlasted the rows before their updates ran. it now gives them twenty and waits for the original expiry measured from a stored write time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a row given an expiry by a session ttl in a table with no ttl of its own kept that expiry on its unchanged index entries when a later update cleared it, so the index lost the row while it still existed. the first such write now records a marker in the table, loaded at open, and from then on every update rewrites the row's index entries with its current expiry, also after a restart. stop words read from a stop word table are lowercased with utf8mb4 case rules rather than ascii only, so an uppercase word outside ascii matches the lowercased text. stale comments on single deletes, bulk batching, value log metering and plugin init now match the code, and the manual and its partitioning example are updated to match