Revert: Set isContinuousLiveboardPDFEnabled to false by default for TSE.#516
Merged
Revert: Set isContinuousLiveboardPDFEnabled to false by default for TSE.#516
isContinuousLiveboardPDFEnabled to false by default for TSE.#516Conversation
commit: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and default behavior for the isWYSIWYGLiveboardPDFEnabled and isContinuousLiveboardPDFEnabled flags in AppEmbed and LiveboardEmbed. Several issues were identified regarding adherence to the style guide: boolean parameters should not be defaulted to false in destructuring to avoid URL bloating, and documentation sentences must end with a period rather than a semicolon. Additionally, the unit tests should be updated to reflect the removal of these unnecessary default parameters from the generated URLs.
|
SonarQube Quality Gate
|
sastaachar
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://thoughtspot.atlassian.net/browse/SCAL-308084