Skip to content

Optimize extraction functions and improve semantic clarity in can? #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theronic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize extraction functions and improve semantic clarity in can? #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/eacl/datomic/impl/indexed.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@
[eacl.core :refer [spice-object]]
[clojure.tools.logging :as log]))

(defn extract-resource-id-from-rel-tuple-datom [{:as _datom, v :v}]
(let [[_subject-type _subject-eid _relation-name _resource-type resource-eid] v]
resource-eid))
(defn extract-resource-id-from-rel-tuple-datom [datom]
"Extracts resource eid from forward relationship tuple (position 4).
Tuple format: [subject-type subject-eid relation-name resource-type resource-eid]"
(nth (:v datom) 4))

(defn extract-subject-id-from-reverse-rel-tuple-datom [{:as _datom, v :v}]
(let [[_resource-type _resource-eid _relation-name _subject-type subject-eid] v]
subject-eid))
(defn extract-subject-id-from-reverse-rel-tuple-datom [datom]
"Extracts subject eid from reverse relationship tuple (position 4).
Tuple format: [resource-type resource-eid relation-name subject-type subject-eid]"
(nth (:v datom) 4))

;(defn find-arrow-permissions
; "Arrows permission means either,
Expand Down Expand Up @@ -253,7 +255,7 @@
reverse-start [resource-type resource-eid via-relation intermediate-type 0] ; cursor = 0 because no pagination.
reverse-end [resource-type resource-eid via-relation intermediate-type Long/MAX_VALUE]
intermediates (->> (d/index-range db reverse-tuple-attr reverse-start reverse-end)
(map extract-resource-id-from-rel-tuple-datom))] ; Extract subject (intermediate) eid
(map extract-subject-id-from-reverse-rel-tuple-datom))] ; Extract subject (intermediate) eid

@theronic theronic Nov 13, 2025

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was incidentally correct before (just made it explicit)

;; Check if subject has the target relation to any intermediate
(some (fn [intermediate-eid]
(let [check-tuple [subject-type subject-eid target-relation
Expand All @@ -270,7 +272,7 @@
reverse-start [resource-type resource-eid via-relation intermediate-type 0] ; cursor = 0 because no pagination.
reverse-end [resource-type resource-eid via-relation intermediate-type Long/MAX_VALUE]
intermediates (->> (d/index-range db reverse-tuple-attr reverse-start reverse-end)
(map extract-resource-id-from-rel-tuple-datom))] ; Extract subject (intermediate) eid
(map extract-subject-id-from-reverse-rel-tuple-datom))] ; Extract subject (intermediate) eid
;; Recursively check permission on any intermediate
(some (fn [intermediate-eid]
(can? db subject target-permission
Expand Down