Make lossy collection APIs explicit and provide a runnable quick start - #74
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60404abccb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ```toml | ||
| [dependencies] | ||
| gatehouse = "=0.6.0-alpha.1" |
There was a problem hiding this comment.
authorize
Following these instructions against crates.io installs the already-published 0.6.0-alpha.1, but that release does not contain BoundEvaluator::authorize (it was introduced later in commit 7c6b212), so the program below fails to compile with a missing-method error. The new CI check masks this because it replaces the dependency with a path to the current checkout; use a released version containing authorize, or make the published quick start compatible with alpha.1.
Useful? React with 👍 / 👎.
1 participant
Collection calls can now make outage omission explicit with
filter_lossy,filter_by_lossy, andlookup_page_lossy. Existing names forward to those methods with targeted deprecation messages; stricttry_*methods and all decision semantics are unchanged. Lossy lookup continues to report lookup, hydration, and adapter-contract errors.The README contains a complete program enforcing access via
check().await.into_result()?, supported by its exact crates.io alpha.1 dependency. The separate consumer checks README parity and runs against the checkout. Its--releasedmode resolves the documented dependency from the registry, without a path override or the checkout lockfile. Both modes pass locally. The alpha.2 release preparation switches the program toauthorize()alongside the version update. Axum handlers already useauthorize.Validation: formatting, all-target/all-feature Clippy, workspace build, full tests, doctests, and both consumer modes pass. Compatibility tests cover old/new lossy equivalence, order, duplicates, projected items, outages, cursor preservation, and pipeline failures.