Add spherical integration using maximum determinant points (#237)#296
Closed
alok-108 wants to merge 2 commits intotheochem:masterfrom
Closed
Add spherical integration using maximum determinant points (#237)#296alok-108 wants to merge 2 commits intotheochem:masterfrom
alok-108 wants to merge 2 commits intotheochem:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This Pull Request introduces the
MaxDeterminantGridclass to thegridlibrary, enabling spherical integration using maximum determinant (Fekete/Extremal) points. This fulfills the requirements outlined in issue #237.Problem
The library currently supports Lebedev quadrature and spherical$t$ -designs. While effective, Lebedev weights can occasionally be negative, and $t$ -designs use uniform weights. Maximum determinant points offer an alternative strategy with strictly positive weights and high numerical stability for integrating functions on the unit sphere.
Solution
Implemented a dedicated
MaxDeterminantGridclass that inherits from the coreGridhierarchy. This implementation follows the library's existing architecture while providing a flexible interface for modern scientific computing.Key Changes
MaxDeterminantGridClass: Implemented insrc/grid/max_det.py. The class features an improvedintegratemethod that supports both callable functions and raw value arrays..npzformat withinsrc/grid/data/max_det/.src/grid/__init__.py.MANIFEST.into ensure the new data files are bundled during installation.Testing & Validation
Added a comprehensive test suite in
src/grid/tests/test_maxdet.pywhich includes:integrate(callable)method is consistent with the baseGrid.integrate(array)logic.Documentation
examples/max_det_integration.ipynbto demonstrate usage results and precision.Fixes #237