Route remaining direct throws through throw_if/throw_unless/throw_anyway - #12
Merged
Conversation
src/ still had 49 call sites across 29 files that threw exceptions directly instead of going through the framework's throw helpers. Convert all of them, dropping the exception class argument where it's already the helper's default (Exception::class), and clean up imports left unused by the change. Also fixes a latent bug in Connection::run_query_callback() surfaced by the conversion: passing $this->db->last_error as a bare argument (rather than inside empty()) made it eager, which raised an undefined-property warning on wpdb doubles missing that property and broke DatabaseGcTest.
ashraful1971
force-pushed
the
chore/throw
branch
from
September 8, 2026 10:46
b495b80 to
7489279
Compare
ahamed
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/ still had 49 call sites across 29 files that threw exceptions directly instead of going through the framework's throw helpers. Convert all of them, dropping the exception class argument where it's already the helper's default (Exception::class), and clean up imports left unused by the change.
Also fixes a latent bug in Connection::run_query_callback() surfaced by the conversion: passing $this->db->last_error as a bare argument (rather than inside empty()) made it eager, which raised an undefined-property warning on wpdb doubles missing that property and broke DatabaseGcTest.