Repository navigation
Conversation
ofedoren
force-pushed
the
add-rackup-support
branch
from
September 30, 2026 11:59
dd9369b to
c837d2b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
theforeman/smart-proxy#955 added Rack 3 support, which raises
undefined method 'rewind' for an instance of Rackup::Handler::WEBrick::Inputwhenever a shellhook is triggered. The issue is that Rack 3.0 bodies are not rewindable per default anymore, we need to include a middleware for backward compatibility now.The second commit adds CI support.