Use RUBY_PLATFORM to decide between rb-inotify and rb-kqueue#884
Open
ekohl wants to merge 3 commits intotheforeman:developfrom
Open
Use RUBY_PLATFORM to decide between rb-inotify and rb-kqueue#884ekohl wants to merge 3 commits intotheforeman:developfrom
ekohl wants to merge 3 commits intotheforeman:developfrom
Conversation
Member
Author
|
Note that |
This matches what modules/dhcp_isc/configuration_loader.rb does in load_programmable_settings. It then also merges into a single dhcp_isc bundler group. The rsec gem is limited to the ruby platfrom because you can't run dhcp_isc on Windows anyway.
Quoting the bundler man page: > The following platform values are deprecated and should be replaced with windows: > * mswin, mswin64, mingw32, x64_mingw Link: https://bundler.io/man/gemfile.5.html#PLATFORMS
ekohl
force-pushed
the
smarter-bundler
branch
from
a312da9 to
150c302
Compare
Member
Author
|
Looks like the last commit doesn't work on older Bundler because the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches what modules/dhcp_isc/configuration_loader.rb does in load_programmable_settings.
Currently untested.