Skip to content

Cherry pick httpproxy false - #932

Closed
pfreyburg wants to merge 3 commits into
theforeman:3.3-stablefrom
pfreyburg:cherry-pick-httpproxy-false
Closed

pfreyburg wants to merge 3 commits into
theforeman:3.3-stablefrom
pfreyburg:cherry-pick-httpproxy-false

Conversation

@pfreyburg

Copy link
Copy Markdown
Contributor

Why are you introducing these changes? (Problem description, related links)

All quadlet container files must explicitly set HttpProxy=false to prevent inter-service communication failures when an HTTP proxy is configured on the Satellite host system.

What are the changes introduced in this pull request?

  • HttpProxy=false is added to all quadlets

How to test this pull request

Steps to reproduce:

Checklist

  • Tests added/updated (if applicable)
  • Documentation updated (if applicable)

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d1b9016b-91d9-4378-b1c4-880b4e3abd4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pfreyburg

Copy link
Copy Markdown
Contributor Author

@vkrizan @evgeni Can you please review?

@vkrizan

vkrizan commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

@pfreyburg there is not much to review if this is a verbatim copy of the earlier PR #920. Please improve the title and consider linking the previous PR. Previous was "add HttpProxy=false to all quadlets".

@evgeni

evgeni commented Oct 13, 2026

Copy link
Copy Markdown
Member

no need to open a pick PR, we're going to pick ourself when planning the next release

@pfreyburg

Copy link
Copy Markdown
Contributor Author

no need to open a pick PR, we're going to pick ourself when planning the next release

Okay, I didn't know this. So I am closing this PR.

@pfreyburg pfreyburg closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants