fix(finance): correct energy-balance period aggregation#72
Merged
tekwani merged 1 commit intotetherto:developfrom May 1, 2026
Merged
fix(finance): correct energy-balance period aggregation#72tekwani merged 1 commit intotetherto:developfrom
tekwani merged 1 commit intotetherto:developfrom
Conversation
The shared aggregateByPeriod summed every numeric field, which is correct for totals but produced nonsense for rates/means (curtailment rate, btcPrice, sitePowerMW, etc.) on weekly/monthly buckets. - Add an optional `meanKeys` arg to aggregateByPeriod that averages listed fields instead of summing. Default behavior is unchanged for the 6 existing callers. - getEnergyBalance now passes meanKeys for sitePowerMW, btcPrice and the rate fields, then post-processes to recompute energyRevenue*_MW against the (correctly meaned) sitePowerMW denominator. - Add sitePowerMW + energyRevenueBTC_MW/energyRevenueUSD_MW to log entries; add avgPowerConsumption + avgEnergyCostPerMWh + avgOperationalCostPerMWh to summary. - Schema: add 'weekly' to the period enum.
paragmore
approved these changes
May 1, 2026
tekwani
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared
aggregateByPeriodsummed every numeric field, which is wrong for rates and per-MW denominators on weekly/monthly buckets. Adds an opt-inmeanKeysoption (existing callers untouched), uses it fromgetEnergyBalance, and exposes a few new fields.FE work to consume this (
useEnergyBalance.hook.ts)periodType→ BEperiod(daily|weekly|monthly); the schema now acceptsweekly.entry.sitePowerMWandentry.energyRevenueBTC_MW/_USD_MWdirectly instead of deriving frompowerW/energyRevenuePerMWh.avgPowerConsumption,avgEnergyCostPerMWh,avgOperationalCostPerMWh,avgRevenuePerMWh.getPeriodKey(entry.ts, periodType)— BE does not return aperiodstring.