fix: processBlockData parses HISTORICAL_BLOCKSIZES flat-array shape#63
Closed
mukama wants to merge 1 commit intotetherto:developfrom
Closed
fix: processBlockData parses HISTORICAL_BLOCKSIZES flat-array shape#63mukama wants to merge 1 commit intotetherto:developfrom
mukama wants to merge 1 commit intotetherto:developfrom
Conversation
The mempool worker's getWrkExtData returns a flat array of block records
[{ts, blockSize, blockReward, blockTotalFees}, ...], but processBlockData
only handled nested .data/.blocks wrappers - it iterated entry's own field
names, Number('ts') returned NaN, and produced an empty daily map. The
SubsidyFee page then rendered "No data available".
Detect the flat shape (entry has .ts/.timestamp/.time) and process it
directly. Also surface blockSize on getSubsidyFees and getRevenueSummary
log entries (and totalBlockSize/avgBlockSize on the summary) - needed for
SubsidyFee's "Avg Fees in Sats/vByte" chart to render after this fix.
This was referenced Apr 28, 2026
Contributor
Author
|
Consolidated into #67. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Bug C from the FE refactor smoke test:
processBlockDatareturned an empty daily map forHISTORICAL_BLOCKSIZESbecause it only handled nested.data/.blockswrappers, not the flat array of block records the mempool worker actually returns. Also surfacesblockSizeon log entries and summary so SubsidyFee's "Avg Fees in Sats/vByte" chart can render.Asana: https://app.asana.com/1/45238840754660/project/1205537444723387/task/1214118019754316
Test plan
standardlint cleandev-moria.tether.to: SubsidyFee renders real data