change value of number input when pressing arrow up or down#1272
Open
Haberkamp wants to merge 1 commit intotesting-library:mainfrom
Open
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Haberkamp
force-pushed
the
pr/change-value-of-number-input-when-pressing-arrow-up-or-down
branch
from
ff2ee1c to
391485b
Compare
Haberkamp
force-pushed
the
pr/change-value-of-number-input-when-pressing-arrow-up-or-down
branch
from
391485b to
c39d029
Compare
greypants
suggested changes
Mar 17, 2025
greypants
left a comment
greypants
left a comment
There was a problem hiding this comment.
Thanks for getting this started! I ran into the same thing today.
I think you're missing handling empty values. Add that, and this would be great to have added!
|
|
||
| const reachedMax = value === node.max | ||
| if (inputData === 'ArrowUp' && !reachedMax) { | ||
| const exceedsMax = Number(value) + step > Number(node.max) |
There was a problem hiding this comment.
What if value is empty? Number(value) will be NaN
There was a problem hiding this comment.
in that case I think value should be treated as "zero" (seems like that's what browsers do)
|
|
||
| const reachedMin = value === node.min | ||
| if (inputData === 'ArrowDown' && !reachedMin) { | ||
| const exceedsMin = Number(value) - step < Number(node.min) |
There was a problem hiding this comment.
same here... need to handle an empty value and bump to zero or the min value? or maybe max?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
With this change you can change the value of a number input by pressing the
ArrowUpandArrowDownkey, like so:Why
In browsers users are able to increment or decrement the value of a number input when pressing the up or down arrow key.
Adding this to
userEventcloses the gap between this package and the browsers.How
Checks if the input field has a
minormaxvalue defined, yes then the value cannot exceed those boundaries. If not the user can increment or decrement the value indefinitely.If the input field has a
stepproperty then it increments or decrements in those steps.Checklist
Resolves #1066