fix(core): Use WaitStrategy internally for wait_for function #942
+9
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(core): Use WaitStrategy internally for wait_for function
Summary
Refactor the deprecated
wait_forfunction to use the newWaitStrategysystem internally instead of the@wait_container_is_readydecorator.This fixes the import-time deprecation warning from #874.
See alexanderankin's comment stating core should no longer warn, and jonaslb's reply identifying that
wait_foris still decorated with@wait_container_is_readyat module level, so it generates a warning.Problem
The
wait_forfunction was decorated with@wait_container_is_ready(), which emits a deprecation warning at decoration time (import time), not when the function is called. This caused warnings even when users never usedwait_for.Reproducer
Note:
wait_foris never called - the warning is emitted just by importing the module.