Skip to content

feat(ui): label github_hmac as 'GitHub / Sentry (X-Hub-Signature-256)' in signing mode picker #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lavie merged 1 commit into from
May 5, 2026
Merged

feat(ui): label github_hmac as 'GitHub / Sentry (X-Hub-Signature-256)' in signing mode picker #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ui/src/pages/RoutineDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ const catchUpPolicyDescriptions: Record<string, string> = {
skip_missed: "Ignore schedule windows that were missed while the routine or scheduler was paused.",
enqueue_missed_with_cap: "Catch up missed schedule windows in capped batches after recovery.",
};
const signingModeLabels: Record<string, string> = {
bearer: "Bearer token",
hmac_sha256: "HMAC SHA-256 (Paperclip format)",
github_hmac: "GitHub / Sentry (X-Hub-Signature-256)",
none: "None (no auth)",
};
const signingModeDescriptions: Record<string, string> = {
bearer: "Expect a shared bearer token in the Authorization header.",
hmac_sha256: "Expect an HMAC SHA-256 signature over the request using the shared secret.",
Expand Down Expand Up @@ -215,10 +221,11 @@ function TriggerEditor({
</SelectTrigger>
<SelectContent>
{signingModes.map((mode) => (
<SelectItem key={mode} value={mode}>{mode}</SelectItem>
<SelectItem key={mode} value={mode}>{signingModeLabels[mode] ?? mode}</SelectItem>
))}
</SelectContent>
</Select>
<p className="text-xs text-muted-foreground">{signingModeDescriptions[draft.signingMode]}</p>
</div>
{!SIGNING_MODES_WITHOUT_REPLAY_WINDOW.has(draft.signingMode) && (
<div className="space-y-1.5">
Expand Down Expand Up @@ -1032,7 +1039,7 @@ export function RoutineDetail() {
</SelectTrigger>
<SelectContent>
{signingModes.map((mode) => (
<SelectItem key={mode} value={mode}>{mode}</SelectItem>
<SelectItem key={mode} value={mode}>{signingModeLabels[mode] ?? mode}</SelectItem>
))}
</SelectContent>
</Select>
Expand Down
Loading