Skip to content

Propagate proxy env to engine-generic workers via engine-cm #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asafyehezkel merged 1 commit into from
Jun 28, 2026
+14 −2
Merged

Propagate proxy env to engine-generic workers via engine-cm #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/tensorleap/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: tensorleap
type: application
version: 1.6.35
version: 1.6.36
dependencies:
- name: ingress-nginx
version: 4.10.0
Expand Down
2 changes: 1 addition & 1 deletion charts/tensorleap/charts/engine/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: v2
name: tensorleap-engine
type: application
version: 1.0.615
version: 1.0.616
12 changes: 12 additions & 0 deletions charts/tensorleap/charts/engine/templates/engine-cm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,17 @@ data:
GENERIC_CALCULATOR_ENTRY_POINT: {{ .Values.entry_point }}
GENERIC_ACTIVATE_NFS: "{{ .Values.metrics_activate_nfs }}"
GENERIC_HOST_PATH: {{ .Values.localDataDirectories | join ":" }}
{{- if .Values.http_proxy }}

@moshe-kabala moshe-kabala Jun 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one is http ant the second is https

HTTP_PROXY: {{ .Values.http_proxy | quote }}
http_proxy: {{ .Values.http_proxy | quote }}
{{- end }}
{{- if .Values.https_proxy }}
HTTPS_PROXY: {{ .Values.https_proxy | quote }}
https_proxy: {{ .Values.https_proxy | quote }}
{{- end }}
{{- if .Values.no_proxy }}
NO_PROXY: {{ .Values.no_proxy | quote }}
no_proxy: {{ .Values.no_proxy | quote }}
{{- end }}