Pass connected funtest on all but js and interp by tjpalmer · Pull Request #465 · temperlang/temper

tjpalmer · 2026-07-21T19:14:42Z

Pass connected functions funtest on all backends except interp and js
Also refine be-py connecteds some
To some extent, this is drafting the plan for userspace connecteds, maybe good approximately as is, but some forms of adjustment wouldn't be too hard
Js is hard because standard import is only top level and our "whatever.internal.js" handling is still awkward
Interp needs some way for backends to know when to use temper impl vs connected code

Signed-off-by: Tom <tom@temper.systems>

tjpalmer · 2026-07-21T20:00:55Z

+// For more on includes, see https://en.cppreference.com/cpp/preprocessor/include#Notes
 Include ::= "#" & "include" & "<" & path%Raw & ">" & "\n";
+/** For string literals, although escapes don't work. */
+IncludeLocal ::= "#" & "include" & path%LiteralExpr & "\n";


Technically not necessarily local-priority includes, but typically all compilers treat them that way, and it at least provides a different convention that can be used by compilers.

Separately, I tried explicit double-quotes around raw to make differences from strings more explicit, but the spacing was off, and it doesn't really accomplish anything.

tjpalmer · 2026-07-21T20:01:40Z

+                    content = file.value,
+                ).also { add(it) }
+            }
+        }


For all the backends, I haven't tested submodules yet. Putting that off for build tests in a future PR.

tjpalmer · 2026-07-21T20:02:03Z

                fileExtensionMap = mapOf(
                    FileType.Module to lang.ext,
                    FileType.Script to lang.ext,
+                    FileType.Header to HPP_EXT,


We need extensions registered for all files we might want to copy.

tjpalmer · 2026-07-21T20:03:10Z

                mimeTypeMap = mapOf(
                    FileType.Module to MimeType.cppSource,
                    FileType.Script to MimeType.cppSource,
+                    FileType.Header to MimeType.cppSource,


We were already supplying this mime type for header files, just not using this map.

tjpalmer · 2026-07-21T20:03:51Z

-                def == WellKnownTypes.dequeTypeDefinition ->
+                WellKnownTypes.dequeTypeDefinition ->
                    return sharedPtr(cpp.template(cppBaseTypeForDefinition(def)!!, typeArgs))
+                else -> {}


The overall change recommended by ij, and it's cleaner overall except for needing the else. Went along with it.

tjpalmer · 2026-07-21T20:49:08Z

+    return i * j
+end
+
+return exports


I made "support" or "more" code for each backend just to prove we have access to them. And made class-like things in each also just for kicks.

tjpalmer · 2026-07-21T20:51:30Z

@@ -0,0 +1,15 @@
+namespace Work
+{
+    static class WorkConnected


We already had <Lib/Mod>Global in be-csharp and be-java, so I reused the same style for <Lib/Mod>Connected for both. But after everyone else is just getting _connected, it's almost tempting to do that for csharp and java also. Or maybe I should make others more idiomatic instead of making these worse. Don't know. These can be refined in future PRs, if we decide for sure to change from what I've made so far.

tjpalmer · 2026-07-21T20:52:17Z

+        internal static int Prod(Hidden hidden, int j)
+        {
+            return new MoreSupport().Prod(hidden.I, j);
+        }


I am trying to make the functions themselves use idiomatic naming. And I've proved I can use the Hidden type in each backend.

tjpalmer · 2026-07-21T20:55:10Z

+    return i + j + bonus
+  end
+
+  ---@param hidden work.Hidden TODO Actually define types in our Lua.


We don't yet generated static EmmyLua (or rather Lua Language Server) typing in our LuaTranslator, and we also don't strip numeric suffices yet. But we also don't need static typing for Lua to work. I just wanted to do static type annotations where possible in the lua connected code in this PR, anyway. This is just the case I can't do yet.

Shaw also would like to make generating type annotations optional in the future, if we do get around to generating them (which I personally would greatly like, as luals is actually pretty high quality in my using it so far in hobby things).

tjpalmer · 2026-07-21T20:55:41Z

    Script,
+
+    /** a header file for pre-declarations */
+    Header,


Felt a bit bad adding this, but C and/or OCaml and/or others might also want header files in the future.

So this just keys into a lookup table for mime types so helps in picking accurate mime-types?

So this just keys into a lookup table for mime types so helps in picking accurate mime-types?

I don't think all backends even use them meaningfully. Looks like FileType.Module gets used in a couple of places. I'm not sure others do at all. But fileExtensionMap and mimeTypeMap in BackendMeta need them. We maybe could adjust in the future. But I needed something other than Module to list .hpp, and JsModule and Script both seemed very wrong.

Signed-off-by: Tom <tom@temper.systems>

mikesamuel

What would it take to have our backend test framework test how backends and translators deal with connected files?

mikesamuel · 2026-07-30T06:23:14Z

-PreProc = Define | Undef | Pragma | IncludeGuard | Include | IfPreProc;
+PreProc = Define | Undef | Pragma | IncludeGuard | Include | IncludeLocal | IfPreProc;
+// For more on includes, see https://en.cppreference.com/cpp/preprocessor/include#Notes
 Include ::= "#" & "include" & "<" & path%Raw & ">" & "\n";


If you run into formatting glitches you could try token references for some of these with specified operator association. Like < as bracket operators instead of as infix.

mikesamuel · 2026-07-30T06:26:53Z

Note to self: these resources are just for the connected functional test.

mikesamuel · 2026-07-30T06:29:13Z

    Script,
+
+    /** a header file for pre-declarations */
+    Header,


So this just keys into a lookup table for mime types so helps in picking accurate mime-types?

mikesamuel · 2026-07-30T06:29:32Z

 | [ControlFlowLoops][] | ✅ | ❌<sup>[198][]</sup> | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ |
 | [FunctionsAsValues][] | ✅ | ❌<sup>[198][]</sup> | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ |
-| [FunctionsConnected][] | ❌<sup>[456][]</sup> | ❌<sup>[198][]</sup> | ❌<sup>[456][]</sup> | ❌<sup>[456][]</sup> | ✅ | ✅ | ❌<sup>[456][]</sup> | ❌<sup>[456][]</sup> | ✅ | ✅ | ❌<sup>[456][]</sup> |
+| [FunctionsConnected][] | ✅ | ❌<sup>[198][]</sup> | ✅ | ❌<sup>[456][]</sup> | ✅ | ✅ | ❌<sup>[456][]</sup> | ✅ | ✅ | ✅ | ✅ |


tjpalmer · 2026-07-30T14:33:13Z

What would it take to have our backend test framework test how backends and translators deal with connected files?

Do you mean just the ...BackendTest suites? If so, it would be fairly easy to include them. I didn't feel like I would get much out of them, but it sounds like you would, so I can add some in future PRs, at least.

tjpalmer added 7 commits July 15, 2026 05:34

Limit the scope of raw python connected code

34e82da

Signed-off-by: Tom <tom@temper.systems>

Pass csharp connected funtest

85df612

Signed-off-by: Tom <tom@temper.systems>

Start adding connected files for cpp

97cd751

Signed-off-by: Tom <tom@temper.systems>

Pass cpp connected funtest

f44c6ba

Signed-off-by: Tom <tom@temper.systems>

Pass lua connected test; refine cpp & py

8ade752

Signed-off-by: Tom <tom@temper.systems>

Pass rust test; adjust py style

6e155e6

Signed-off-by: Tom <tom@temper.systems>

Update matrix; fix lint

15f4a07

Signed-off-by: Tom <tom@temper.systems>

tjpalmer changed the title ~~Pass connected funtest on all but js~~ Pass connected funtest on all but js and interp Jul 21, 2026

tjpalmer commented Jul 21, 2026

View reviewed changes

Delete debug code

84403f1

Signed-off-by: Tom <tom@temper.systems>

tjpalmer marked this pull request as ready for review July 21, 2026 22:14

tjpalmer mentioned this pull request Jul 29, 2026

Support be-js connected code in funtests #470

Merged

mikesamuel approved these changes Jul 30, 2026

View reviewed changes

tjpalmer merged commit 88f4798 into main Jul 30, 2026
2 checks passed

tjpalmer deleted the more-connected branch July 30, 2026 14:55

tjpalmer mentioned this pull request Jul 31, 2026

Userspace @connected methods #456

Open

7 tasks

Uh oh!

Conversation

tjpalmer commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikesamuel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tjpalmer commented Jul 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tjpalmer commented Jul 21, 2026 •

edited

Loading