Fix #443: add missing % to nonNegativePercent pattern in ODF 1.4 schema - #444
Merged
Merged
Conversation
|
svanteschubert
approved these changes
Aug 23, 2026
svanteschubert
left a comment
svanteschubert
left a comment
Contributor
There was a problem hiding this comment.
Well spotted!
I remember the issue and a quick compare with the published RNG at OASIS:
https://docs.oasis-open.org/office/OpenDocument/v1.4/os/schemas/OpenDocument-v1.4-schema-rng.html#7078
proofed your claim!
Thank you very much!
Svante
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pattern for
nonNegativePercentinvalidator/src/main/resources/schema/odf1.4/OpenDocument-v1.4-schema.rngis missing the%sign. This is the same fix Regina Henschel made in LibreOffice core for tdf#162687.I ran into this because LibreOffice writes
draw:extrusion-specularity="0%"whenever a shape has a 3D extrusion, so any ODF 1.4 document with an extruded shape gets reported as invalid.I tested with odfvalidator 0.13.0 on a small .odt from LibreOffice 26.2 containing one extruded rectangle — it fails before this change and passes after. Happy to attach the file if it's useful.