Skip to content

Potential regression in JavaScriptCore support #114

Description

@jugglinmike

A recent change to the JavaScriptCore "agent" may have regressed JSC support. Commit 4e9c3ee (which was first released in eshost version 8.0.0) includes the following modification

-  let env = Object.assign({}, process.env, { DYLD_FRAMEWORK_PATH });
   this.cpOptions = {
-    env
+    ...process.env,
+    DYLD_FRAMEWORK_PATH
   };
 }

Prior to that change, the object assigned to this.cpOptions had a single property, and that property was named env. The change caused this.cpOptions to become the value which was previously defined as the env property. As far as I can tell, none of the references to the property were updated to reflect this change.

I have not observed any regressions related to this change since the release of version 8.0.0.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions