Fix race condition when launching Oxide helper process #1520
+80
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1519
We were calling
startIfNeeded()but it did async work before assigning the connection which means if scan() is called once per project the flow looks like this:Project 1-N:
scan()->startIfNeeded()-> check for existing connection ->await …-> setup connection -> doneSince projects are loaded via
Promise.all(…)every single one will run all the way up to theawaitcall, wait, fork a process, setup an RPC connection, and overwrite thethis.helperandthis.connectionproperties. I think the additional processes would stick around because of closure scopes but not 100% sure about that as they should've otherwise been unreferenced.This PR changes the setup in a few ways: