Repository navigation
Conversation
Instead of running as root we should really prefer to run unprivileged. This can be done by using the DynamicUser=yes in the unit and by having a polkit rule that allows the bridge to talk to the various varlink services. This is hardening, effectively the bridge is still root because it can start processes as root via varlink. The other nice benefit of it is that by using polkit we can potentially limit the usage more fine-grained. We also plan to add more features to polkit and systemd to carry more information from the bridge so that we can take data from the bridge authentication into account when making the authorization decisions.
The bridge now runs without root so we need to make sure the import-ssh keys are readable by non-root. As those are pub-keys writing with 0644 is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of running as root we should really prefer to run unprivileged. This can be done by using the DynamicUser=yes in the unit and by having a polkit rule that allows the bridge to talk to the various varlink services.
This is hardening, effectively the bridge is still root because it can start processes as root via varlink. The other nice benefit of it is that by using polkit we can potentially limit the usage more fine-grained. We also plan to add more features to polkit and systemd to carry more information from the bridge so that we can take data from the bridge authentication into account when making the authorization decisions.