This repository was archived by the owner on Jan 22, 2024. It is now read-only.
Compat with mkosi 18#31
Open
keszybz wants to merge 5 commits into
Open
Conversation
This saves 700k.
There were many incompatible changes, and I don't see a way to have a version that works with both versions. With those changes, it seems to work again.
depmod complains if those files are missing, and it seems we really need them to correctly load all modules. This means that we need both files. Usually, kernel-core will be installed if kernel-modules-core is, so it's not such a big issue.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
keszybz
force-pushed
the
compat-with-mkosi-18
branch
from
a317047 to
61a88dc
Compare
| if not (copy_in_modules_from_rpmls(root, rpms) or | ||
| copy_in_modules_from_fs(root, kver) or | ||
| copy_in_modules_from_cpio(root, rpms)): | ||
| raise Exception(f'Failed to copy modules for kernel {kver}') |
Check warning
Code scanning / vcs-diff-lint
copy_in_modules_kver: Raising too general exception: Exception
daandemeyer
reviewed
Oct 12, 2023
| cd "$BUILD_DIR" | ||
|
|
||
| mkosi --default /usr/lib/mkosi-initrd/fedora.mkosi \ | ||
| mkosi --include=/usr/lib/mkosi-initrd/mkosi.conf \ |
There was a problem hiding this comment.
You can just specify /usr/lib/mkosi-initrd here and it will pick up the finalize script automatically.
Member
Author
There was a problem hiding this comment.
I think it's better to be explicit.
Member
Author
Hmm. |
|
Maybe running into rpm-software-management/librepo#284? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.